Closed johnpneumann closed 6 years ago
This looks nice, does this solve #70 and #71 as well by any chance?
Love the test script, do you think it can be included into travis?
LGTM. With the test script included in Travis, this would get my thumb up. 👍
resolves #77.
The issue with the fix proposed in #66 is that the markdown-resume directory will always be within the path even when it's added as a package in its own composer file. As such, it means that the first argument in the ternary operator will always return.
If you want to test this:
Hopefully that's clear as mud. I haven't written PHP in a decade and have no experience with composer outside of today, so if there's a better way for this, feel free to correct.