therealLucasPaul / ORSEE_Test

0 stars 0 forks source link

Ethics approval module #53

Open therealLucasPaul opened 1 year ago

therealLucasPaul commented 1 year ago

Author: Yuta Dear all,

I notice the following behavior. When I create an experiment, if I enter the ethics approval number and set the expiration date, only the Basic settings are displayed on the experiment page, and the Sessions and Participants frames are not displayed. If I do not set an expiration date for the ethics review and check the Exempt checkbox, the Sessions and Participants frames are displayed. If I leave the ethics approval number and organization name blank, the Sessions and Participants frames are displayed, but this makes the ethics approval module useless. This behavior seems to be a bug.

Best, Yuta

therealLucasPaul commented 10 months ago

Author: Matthew I'm getting the same issue after upgrading. Seems like the issue only appears if an experiment has no sessions (as when newly created). A workaround is to create a dummy session before enabling the ethics approval.

My guess about the problem is that it's something different introduced in PHP 8. Code fix I think is to set =-1 on line 63 of admin/experiment_show.php.