search

therealguy90 / foundrytodiscord

A FoundryVTT module that sends all FoundryVTT messages to a Discord webhook.
https://ko-fi.com/loki123
MIT License
15 stars 2 forks source link

Failure to send messages to discord when token image has spaces in its filename. #33

Closed Opius134 closed 8 months ago

Opius134 commented 8 months ago

This bug is present in Foundry Version 11 (11.315) while running in the DnD5e Game System (3.0.4)

To Reproduce Select a token with a space in its filename and attempt to send a message.

The chat message appears in Foundry without issue, but it fails to get to Discord. Console log spits out a 404 error.

Expected behavior The resulting message should mirror from Foundry chat to the linked Discord channel.

Screenshots image image

Additional context After testing, I think this issue came up by using Aedif's Token Variant Art during token configuration. Selecting a file through the normal file browser appends a '%20' on spaces in filenames, whereas going through the token variant retains the filename space.

therealguy90 commented 8 months ago

Yeah, this is because back in v9 or v10, can't remember which, filepaths on Foundry weren't using an encoded URI scheme, which is probably retained in that module. There are two ways to go about this: opening an issue on Aedif's Token Variant to make the filepaths properly encoded, or I can just fix it myself here.

therealguy90 commented 8 months ago

Should be fixed in c4ca4de476f64bb2422827cc724f64743e7b7d1e of the 2.0 branch. Unfortunately, Foundry's FilePicker doesn't have a native way to encode file paths, so I had to do it manually through crawling. Other special characters should be included too, not just spaces.

therealguy90 commented 8 months ago

Fixed in 2.0.0.