search

therealklanni / badger

Ingress Agent Community ID Badge Creator
MIT License
42 stars 20 forks source link

Support for Coda font #49

Closed mattdbr closed 9 years ago

mattdbr commented 9 years ago

Code font added. Fix for issue #48

therealklanni commented 9 years ago

Thanks very much for taking the initiative to get this enhancement request done! Just a couple of things I need you to resolve before I can merge your changes:

  1. I just realized that you've made all the changes to the dist/ files instead of their sources. The files in dist/ are generated automatically, producing the compiled/end-product (i.e. distribution copy) of the site and should not be modified directly. So please make the necessary changes to the appropriate files in app/ instead.
  2. Please do not include any changes that are not directly related to the subject of the PR (in this case, adding Coda font). If you think other changes should be made, please open a separate PR for those, so they can be reviewed independently of the Coda font changes.

Thanks again! :metal:

mattdbr commented 9 years ago

Not sure how some of those changes snuck in, I was using a fresh clone. Somehow some old files must have gotten in the way.

JS isn't my language of choice, I didn't understand how the dist/ files were being generated, that will be fixed.

I'll fix the other stuff when my internet stops being shaped, apologies for the inconvenience (you can see that programming isn't my profession ;) )

On Mon, Dec 8, 2014 at 6:57 AM, Kevin Lanni notifications@github.com wrote:

Thanks very much for taking the initiative to get this enhancement request done! Just a couple of things I need you to resolve before I can merge your changes:

1.

I just realized as well that you've made all the changes to the dist/ files instead of their sources. The files in dist/ are generated automatically, producing the compiled/end-product (i.e. distribution copy) of the site and should not be modified directly. So please make the necessary changes to the appropriate files in app/ instead. 2.

Please do not include any changes that are not directly related to the subject of the PR (in this case, adding Coda font). If you think other changes should be made, please open a separate PR for those, so they can be reviewed independently of the Coda font changes.

Thanks again! [image: :metal:]

— Reply to this email directly or view it on GitHub https://github.com/therealklanni/badger/pull/49#issuecomment-65951268.

mattdbr commented 9 years ago

Just worked out why they snuck in, I didn't clone from the dev branch

On Mon, Dec 8, 2014 at 11:30 AM, Matthew Brener akkatracker@gmail.com wrote:

Not sure how some of those changes snuck in, I was using a fresh clone. Somehow some old files must have gotten in the way.

JS isn't my language of choice, I didn't understand how the dist/ files were being generated, that will be fixed.

I'll fix the other stuff when my internet stops being shaped, apologies for the inconvenience (you can see that programming isn't my profession ;) )

On Mon, Dec 8, 2014 at 6:57 AM, Kevin Lanni notifications@github.com wrote:

Thanks very much for taking the initiative to get this enhancement request done! Just a couple of things I need you to resolve before I can merge your changes:

1.

I just realized as well that you've made all the changes to the dist/ files instead of their sources. The files in dist/ are generated automatically, producing the compiled/end-product (i.e. distribution copy) of the site and should not be modified directly. So please make the necessary changes to the appropriate files in app/ instead. 2.

Please do not include any changes that are not directly related to the subject of the PR (in this case, adding Coda font). If you think other changes should be made, please open a separate PR for those, so they can be reviewed independently of the Coda font changes.

Thanks again! [image: :metal:]

— Reply to this email directly or view it on GitHub https://github.com/therealklanni/badger/pull/49#issuecomment-65951268.

therealklanni commented 9 years ago

Thanks! I really appreciate your contributions :+1: