PA Review: User Authentication

[therealmeyer]

• [ ] Backend: DB, model, controller, views,
• [ ] Redux Loop: ajax, actions, reducer
• [ ] Presentational Components
• [ ] Styling
• [ ] Smooth, bug-free navigation
• [ ] Adequate and appropriate seeds

[AAlfarho]

Hi there Ryan, great job with your current user auth there only a couple of minor details before closing this feature.

• [x] Let's add a whitespace in the signup modal, currently, it is SignUp.
• [x] Going to a random route /#/randomroute should redirect to either /, /login, or /signup. This means we need a default route in our switch.
• [x] What do you think about removing the login label at the top of your modal? It feels out of place
  • 

Feel free to check the items in this list and assign this issue back to me once the mentioned points are addressed.

[therealmeyer]

Completed tasks

[AAlfarho]

Great job!

The red outline when errors occurr look great, one last cosmetic detail is that the current error messages are a bit off with respect to the rest of the form.

[therealmeyer]

Thanks for that catch. I reformatted the inputs and buttons but forgot about the errors!

On Thu, Jun 7, 2018 at 3:29 PM Andres Alfaro notifications@github.com wrote:

Great job!

The red outline when errors occurr look great, one last cosmetic detail is that the current error messages are a bit off with respect to the rest of the form. [image: screen shot 2018-06-07 at 3 16 06 pm] https://user-images.githubusercontent.com/1103663/41129362-836ee78e-6a66-11e8-926d-05023bfb6522.png

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/therealmeyer/SonicStratus/issues/2#issuecomment-395585987, or mute the thread https://github.com/notifications/unsubscribe-auth/APlrSy-GCiHveqhbueSRSTPj0eF3Tpugks5t6alXgaJpZM4UdiKY .

[therealmeyer]

Completed errors tasks

• [ ] errors correctly formatted