therealpaulgg / ssh-sync

An SSH syncing application built with Go.
https://sshsync.io/
MIT License
4 stars 1 forks source link

Add more graceful response if successful challenge-response but the challenger quit the session #28

Closed therealpaulgg closed 3 months ago

therealpaulgg commented 4 months ago

Example of this behavior:

Client starts challenge, and quits (ctrl+c)

On other machine this happens:

ssh-sync challenge-response
Please enter the challenge phrase: stranger-enzyme-buckshot
failed to parse PEM encoded key: failed to decode PEM data

Expected behavior would be that the challenge should clean itself up when the challenger quits their session, and when the challenge response occurs it should say invalid challenge.

ssh-sync challenge-response
Please enter the challenge phrase: stranger-enzyme-buckshot
error from server: Invalid challenge response
therealpaulgg commented 3 months ago

This is fixed in this pull request. https://github.com/therealpaulgg/ssh-sync-server/pull/17