therealprof / display-interface

Rust crates providing a generic interface for display drivers and some default implementations (GPIO, SPI and I2C)
Apache License 2.0
73 stars 27 forks source link

Simplify parallel GPIO interface and add new error variant #13

Closed andresovela closed 3 years ago

andresovela commented 3 years ago

I simplified the API for the parallel GPIO interface by grouping the bus into an array of pins rather than 8 individual pins. This allows to further simplify the set_value() function.

I also added a new variant to the DisplayError enum to represent issues that arise while asserting or de-asserting the reset pin. That is not used in these crates, but it is a useful error to have for consumers of this library.

andresovela commented 3 years ago

I split this PR into #14, #15 and #16. I didn't bump the crate's version this time. I'll leave it to you for when you want to make another release.