search

therealprof / display-interface

Rust crates providing a generic interface for display drivers and some default implementations (GPIO, SPI and I2C)
Apache License 2.0
73 stars 27 forks source link

Adds support for embedded-hal v1.0.0-alpha.8 traits #26

Closed almindor closed 2 years ago

almindor commented 2 years ago

Adds support for the alpha.8 of v1.0.0 embedded-hal for SPI

I don't have I2C to test those changes

therealprof commented 2 years ago

Looks good to me. Are you planning more changes or should we just go for it?

almindor commented 2 years ago

Looks good to me. Are you planning more changes or should we just go for it?

Yes, but I'm unsure of the release mode. I don't think this should go to master until embedded-hal v1.0 is out of alpha. We could merge it into a branch and do crates pre-release so people can use that version easier (similar to how embedded-hal alpha pre-releases are pushed out)

therealprof commented 2 years ago

I'm not really worried at all, we could even release it as an alpha; pre-releases are not automatically picked up by cargo so nothing should break.

almindor commented 2 years ago

I'm not really worried at all, we could even release it as an alpha; pre-releases are not automatically picked up by cargo so nothing should break.

Ok :) I'll let you punch it.

bindermuehle commented 1 year ago

I'm not quite sure what release procedures are used. I just wanted to inform you that the 0.5.0-alpha.1 version has not been release to cargo yet.