Adherence to Drupal 8 coding standards.

[paraacha]

The Drupal 8 coding standards are missing in a few places in the module. This issue is just a reminder to fix those eventually.

In src/TfaBasePlugin.php,

• Missing doc comment for getLabel() function.

  In src/TfaLoginPluginManager.php,

• Empty doc comment for the class.

  In src/TfaSendPluginManager.php,

• Empty doc comment for the class.

  In src/TfaSetup/TfaTrustedBrowserSetup.php,

• Missing newline at the end-of-file.
• Multiple blank lines after deleteTrustedBrowsers() function.
• Comment present after a statement in validateSetupForm() function.

  In src/TfaLogin/TfaTrustedBrowser.php,

• use Drupal\tfa\TfaDataTrait; is an unused use statement.

  In src/TfaValidation/TfaHotp.php,

• Missing space after closing parenthesis in isFallback() function.

  In src/TfaValidation/TfaTotp.php,

• use Drupal\Core\Url; is an unused use statement.

  In tfa.module,

• In hook implementations, there is no need to document function parameters because they've already been documented in the hook documentation. So,

/**
 * Implements hook_user_login()
 *
 * @param $account
 */

should be replaced with:

/**
 * Implements hook_user_login().
 */

and

/**
 * Implements hook_block_access()
 *
 * Remove access to the core user_login_block so we can replace with the TFA login block.
 *
 * @param \Drupal\block\Entity\Block $block
 * @param $operation
 * @param \Drupal\user\Entity\User $account
 *
 * @return \Drupal\Core\Access\AccessResult
 */

should be replaced with this also taking care of the 80 chars line limit:

/**
 * Implements hook_block_access().
 *
 * Remove access to the core user_login_block so we can replace with the TFA
 * login block.
 */

In tfa.install

• Missing description in @file comment.

  In src/Form/BasicOverview.php

• Several unused use statements present.

  In _servicestfa/src/Plugin/ServiceDefinition/GenericValidation.php

• Missing newline at the end-of-file.

[nerdstein]

👍