search

therebelrobot / countryjs

[unmaintained] A module for returning data about countries, ISO info and states/provinces within them. Browserify-compatible
http://country.js.org
120 stars 88 forks source link

Replace bulk-require #58

Closed chrisforrette closed 7 years ago

chrisforrette commented 7 years ago

This replaces the bulk-require package with require-all, which fixes #57 . I started by adding the test test/data.test.js to ensure that the updated implementation didn't change anything. A main difference in the two packages is that require-all returns an object with file names as keys rather than an array from bulk-require, which is addressed in the new implementation in data/index.js.

chrisforrette commented 7 years ago

@BrandonCopley Did I open this PR in the right place? Or should this be pointed at https://github.com/progressclaim/countryjs?

BrandonCopley commented 7 years ago

Thanks just needed the ping! merging in now.

chrisforrette commented 7 years ago

@BrandonCopley Awesome, thank you!

BrandonCopley commented 7 years ago

It is now pushed and uploaded to NPM, sorry for the delay, this got mixed in with updates I was receiving for another github project I don't have control over.

-- [image: Giftnix]

Brandon Copley

Founder & CEO

t: 512.784.6060 <(512)%20784-6060>

e: copley.brandon@gmail.com

On Mon, Apr 24, 2017 at 5:11 PM, Chris Forrette notifications@github.com wrote:

@BrandonCopley https://github.com/BrandonCopley Awesome, thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/therebelrobot/countryjs/pull/58#issuecomment-296836578, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJShr7KHLuGPhAfVatJDMq4ii3yfeHlks5rzR4YgaJpZM4NDvVz .