my.awqlOptions being overwritten with 2 parallel calls

therebelrobot / google-adwords

A Node.js driver for Google Adwords Reporting API (v201509)

14 stars 24 forks source link

my.awqlOptions being overwritten with 2 parallel calls #8

Open joeycozza opened 9 years ago

joeycozza commented 9 years ago

The problem occurs with 2 separate calls to self.awql. my.awqlOptions gets overwritten there, then later lib/googleadwords.js line 130 sets the variable my.awqlOptions to an empty object, so a race condition is happening.

It seems like it would be better to have the options get passed into _sendAWQL instead of using single modular level variable.

therebelrobot commented 9 years ago

Good catch. I'll refactor that in soon.

AlonMiz commented 8 years ago

Any ideas solving that issue? Making each call forcing a delay of at least 1.5 secs.

therebelrobot commented 8 years ago

@AlonMiz This module is no longer being actively maintained. Please refer to https://github.com/therebelrobot/google-adwords#google-adwords for more info. If you'd like to take up maintaining it, let me know, I just don't have the bandwidth for it anymore.