therecluse26 / PHP-Login

A login system built with PHP, MySQL, jQuery and Bootstrap
MIT License
836 stars 442 forks source link

Error in admin/maillog.php #168

Closed Abysmal closed 6 years ago

Abysmal commented 6 years ago

PHP Warning: Illegal string offset 'rowcount' in ../admin/maillog.php on line 16 PHP Warning: Illegal string offset 'rowcount' in ../admin/maillog.php on line 22

Abysmal commented 6 years ago

I think the issue isn't the 'rowcount' but more over the empty array being returned because the table is not found..

dbconfig.php

$tbl_prefix = ""; //Prefix for all database tables $tbl_members = $tbl_prefix."members"; $tbl_memberinfo = $tbl_prefix."memberinfo"; ==> Missing in DB Table Name $tbl_admins = $tbl_prefix."admins"; $tbl_attempts = $tbl_prefix."loginattempts"; ==> Missing in DB Table Name $tbl_deleted = $tbl_prefix."deletedmembers"; ==> Missing in DB Table Name $tbl_tokens = $tbl_prefix."tokens"; $tbl_cookies = $tbl_prefix."cookies"; $tbl_appConfig = $tbl_prefix."app_config"; $tbl_mailLog = $tbl_prefix."maillog"; ==> Missing in DB Table Name

mySQL Tables

admins app_config cookies deletedmembers loginattempts maillog memberinfo members tokens

therecluse26 commented 6 years ago

How did you install this? Did you maybe run into any errors during the install process? All of those tables should be created automatically in both the automated installer and the manual installation cases.

Abysmal commented 6 years ago

The database was a manual create and install because I was getting errors creating the triggers.. Being on a shared cpanel host, the DB users are all prefixed with the owner name ie: "xxxxxxxx_" but the auto install assigns the triggers to the 'root@localhost' so I have to change them.. But the db setup sql is what created the tables..

k.

Abysmal commented 6 years ago

These are defined in install/manual/sql/PHPLoginDbRal.sql and phplogindb.txt

therecluse26 commented 6 years ago

Ah I'm seeing it now, good catch. I just pushed changes there, go ahead and pull those back in and retry the install process. Sorry about that!

On Thu, Mar 29, 2018 at 3:52 PM, Abysmal notifications@github.com wrote:

These are defined in install/manual/sql/PHPLoginDbRal.sql and phplogindb.txt

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/therecluse26/PHP-Login/issues/168#issuecomment-377352311, or mute the thread https://github.com/notifications/unsubscribe-auth/AH24AkjAkyA84zSreW2tdRYt8P9bEAFtks5tjTtrgaJpZM4TAxZ0 .

Abysmal commented 6 years ago

Sorry is not needed.. You’re doing an amazing job with the project!!!

Any changes for the Triggers expecting the ‘root’ user?

therecluse26 commented 6 years ago

Thank you! I hope it serves you well :)

I also didn't notice that those definers were requiring the root user. I don't think a ton of people have been using the manual method that I'm aware of, so you're the first person to point that out to date. Let me see what I can come up with for that and get back to you.

Abysmal commented 6 years ago

It does it with the automated install as well unless I pre-change the file..

Sent from my iPad

On Mar 29, 2018, at 6:30 PM, Brad notifications@github.com wrote:

Thank you! I hope it serves you well :)

I also didn't notice that those definers were requiring the root user. I don't think a ton of people have been using the manual method that I'm aware of, so you're the first person to point that out to date. Let me see what I can come up with for that and get back to you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

therecluse26 commented 6 years ago

Which file are you pre-changing? I'm not seeing that issue in the automated install scripts anywhere. For the manual installer, I just lazily generated and edited the scripts output by MySQL, so it included that extra line for adding a "DEFINER" for the triggers, but those don't exist anywhere in the automated script

On Thu, Mar 29, 2018 at 6:44 PM, Abysmal notifications@github.com wrote:

It does it with the automated install as well unless I pre-change the file..

Sent from my iPad

On Mar 29, 2018, at 6:30 PM, Brad notifications@github.com wrote:

Thank you! I hope it serves you well :)

I also didn't notice that those definers were requiring the root user. I don't think a ton of people have been using the manual method that I'm aware of, so you're the first person to point that out to date. Let me see what I can come up with for that and get back to you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/therecluse26/PHP-Login/issues/168#issuecomment-377395015, or mute the thread https://github.com/notifications/unsubscribe-auth/AH24Ahphv-360uTBtBoWKyXgu80htgr3ks5tjWPbgaJpZM4TAxZ0 .

Abysmal commented 6 years ago

Let me know how I can help..

Sent from my iPad

On Mar 29, 2018, at 6:30 PM, Brad notifications@github.com wrote:

Thank you! I hope it serves you well :)

I also didn't notice that those definers were requiring the root user. I don't think a ton of people have been using the manual method that I'm aware of, so you're the first person to point that out to date. Let me see what I can come up with for that and get back to you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Abysmal commented 6 years ago

I would have to look which file i had to change... I had a few failures.. I guess I should pay more attention.. and record everything..

Sent from my iPad

On Mar 29, 2018, at 7:51 PM, Brad notifications@github.com wrote:

Which file are you pre-changing? I'm not seeing that issue in the automated install scripts anywhere. For the manual installer, I just lazily generated and edited the scripts output by MySQL, so it included that extra line for adding a "DEFINER" for the triggers, but those don't exist anywhere in the automated script

On Thu, Mar 29, 2018 at 6:44 PM, Abysmal notifications@github.com wrote:

It does it with the automated install as well unless I pre-change the file..

Sent from my iPad

On Mar 29, 2018, at 6:30 PM, Brad notifications@github.com wrote:

Thank you! I hope it serves you well :)

I also didn't notice that those definers were requiring the root user. I don't think a ton of people have been using the manual method that I'm aware of, so you're the first person to point that out to date. Let me see what I can come up with for that and get back to you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/therecluse26/PHP-Login/issues/168#issuecomment-377395015, or mute the thread https://github.com/notifications/unsubscribe-auth/AH24Ahphv-360uTBtBoWKyXgu80htgr3ks5tjWPbgaJpZM4TAxZ0 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

therecluse26 commented 6 years ago

Ok, I just pushed the change that removes the root user restriction, so pull those in and try restarting the install process

On Thu, Mar 29, 2018 at 8:14 PM, Abysmal notifications@github.com wrote:

I would have to look which file i had to change... I had a few failures.. I guess I should pay more attention.. and record everything..

Sent from my iPad

On Mar 29, 2018, at 7:51 PM, Brad notifications@github.com wrote:

Which file are you pre-changing? I'm not seeing that issue in the automated install scripts anywhere. For the manual installer, I just lazily generated and edited the scripts output by MySQL, so it included that extra line for adding a "DEFINER" for the triggers, but those don't exist anywhere in the automated script

On Thu, Mar 29, 2018 at 6:44 PM, Abysmal notifications@github.com wrote:

It does it with the automated install as well unless I pre-change the file..

Sent from my iPad

On Mar 29, 2018, at 6:30 PM, Brad notifications@github.com wrote:

Thank you! I hope it serves you well :)

I also didn't notice that those definers were requiring the root user. I don't think a ton of people have been using the manual method that I'm aware of, so you're the first person to point that out to date. Let me see what I can come up with for that and get back to you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/therecluse26/PHP-Login/issues/ 168#issuecomment-377395015, or mute the thread https://github.com/notifications/unsubscribe-auth/AH24Ahphv- 360uTBtBoWKyXgu80htgr3ks5tjWPbgaJpZM4TAxZ0 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/therecluse26/PHP-Login/issues/168#issuecomment-377409860, or mute the thread https://github.com/notifications/unsubscribe-auth/AH24AgVRCE4UdtZHb9NGmRhLzYcG0LKrks5tjXjpgaJpZM4TAxZ0 .

Abysmal commented 6 years ago

Okay.. will try again over the weekend

Sent from my iPad

On Mar 29, 2018, at 9:02 PM, Brad notifications@github.com wrote:

Ok, I just pushed the change that removes the root user restriction, so pull those in and try restarting the install process

On Thu, Mar 29, 2018 at 8:14 PM, Abysmal notifications@github.com wrote:

I would have to look which file i had to change... I had a few failures.. I guess I should pay more attention.. and record everything..

Sent from my iPad

On Mar 29, 2018, at 7:51 PM, Brad notifications@github.com wrote:

Which file are you pre-changing? I'm not seeing that issue in the automated install scripts anywhere. For the manual installer, I just lazily generated and edited the scripts output by MySQL, so it included that extra line for adding a "DEFINER" for the triggers, but those don't exist anywhere in the automated script

On Thu, Mar 29, 2018 at 6:44 PM, Abysmal notifications@github.com wrote:

It does it with the automated install as well unless I pre-change the file..

Sent from my iPad

On Mar 29, 2018, at 6:30 PM, Brad notifications@github.com wrote:

Thank you! I hope it serves you well :)

I also didn't notice that those definers were requiring the root user. I don't think a ton of people have been using the manual method that I'm aware of, so you're the first person to point that out to date. Let me see what I can come up with for that and get back to you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/therecluse26/PHP-Login/issues/ 168#issuecomment-377395015, or mute the thread https://github.com/notifications/unsubscribe-auth/AH24Ahphv- 360uTBtBoWKyXgu80htgr3ks5tjWPbgaJpZM4TAxZ0 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/therecluse26/PHP-Login/issues/168#issuecomment-377409860, or mute the thread https://github.com/notifications/unsubscribe-auth/AH24AgVRCE4UdtZHb9NGmRhLzYcG0LKrks5tjXjpgaJpZM4TAxZ0 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Abysmal commented 6 years ago

I just installed and tested with the latest version and All works as expected. I used the Automatic Installation.