search

therecluse26 / PHP-Login

A login system built with PHP, MySQL, jQuery and Bootstrap
MIT License
839 stars 444 forks source link

MySQL #238

Closed manalshaikh closed 5 years ago

manalshaikh commented 5 years ago

Please make it into mysqli or PDO. mysql_connect doesn't work anymore.

therecluse26 commented 5 years ago

Could you please explain what the purpose of this pull request is? It looks like you're just replacing PDO with the older, less-secure mysqli library.

therecluse26 commented 5 years ago

This already uses PDO, it doesn’t use mysql_connect... where are you getting that idea?

On Sep 7, 2019 at 5:41 PM, <Manal Shaikh (mailto:notifications@github.com)> wrote:

Please make it into mysqli or PDO. mysql_connect doesn't work anymore.

You can view, comment on, or merge this pull request online at:

https://github.com/therecluse26/PHP-Login/pull/238

Commit Summary

Adding Register functionality

Switching back to mysql functions

Using password hashing

Minor change

Updating readme.MD

Updating readme

File Changes

M README.md (https://github.com/therecluse26/PHP-Login/pull/238/files#diff-0) (55)

A adduser.php (https://github.com/therecluse26/PHP-Login/pull/238/files#diff-1) (42)

M checklogin.php (https://github.com/therecluse26/PHP-Login/pull/238/files#diff-2) (90)

M config.php (https://github.com/therecluse26/PHP-Login/pull/238/files#diff-3) (3)

A createuser.php (https://github.com/therecluse26/PHP-Login/pull/238/files#diff-4) (44)

M images/screenshot.png (https://github.com/therecluse26/PHP-Login/pull/238/files#diff-5) (0)

M index.php (https://github.com/therecluse26/PHP-Login/pull/238/files#diff-6) (3)

A js/create.js (https://github.com/therecluse26/PHP-Login/pull/238/files#diff-7) (45)

M main_login.php (https://github.com/therecluse26/PHP-Login/pull/238/files#diff-8) (91)

Patch Links:

https://github.com/therecluse26/PHP-Login/pull/238.patch

https://github.com/therecluse26/PHP-Login/pull/238.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub (https://github.com/therecluse26/PHP-Login/pull/238?email_source=notifications&email_token=AB63QARLB2BE3N2R53PFKQDQIQNY3A5CNFSM4IURLYP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJ7HMGQ), or mute the thread (https://github.com/notifications/unsubscribe-auth/AB63QAU3C24JETKYXYVF7DTQIQNY3ANCNFSM4IURLYPQ).

manalshaikh commented 5 years ago

I'll need to recheck. The last time I saw was Mysql_connect

On Sun 8 Sep, 2019, 3:18 AM therecluse26, notifications@github.com wrote:

This already uses PDO, it doesn’t use mysql_connect... where are you getting that idea?

On Sep 7, 2019 at 5:41 PM, <Manal Shaikh (mailto: notifications@github.com)> wrote:

Please make it into mysqli or PDO. mysql_connect doesn't work anymore.

You can view, comment on, or merge this pull request online at:

https://github.com/therecluse26/PHP-Login/pull/238

Commit Summary

Adding Register functionality

Switching back to mysql functions

Using password hashing

Minor change

Updating readme.MD

Updating readme

File Changes

M README.md ( https://github.com/therecluse26/PHP-Login/pull/238/files#diff-0) (55)

A adduser.php ( https://github.com/therecluse26/PHP-Login/pull/238/files#diff-1) (42)

M checklogin.php ( https://github.com/therecluse26/PHP-Login/pull/238/files#diff-2) (90)

M config.php ( https://github.com/therecluse26/PHP-Login/pull/238/files#diff-3) (3)

A createuser.php ( https://github.com/therecluse26/PHP-Login/pull/238/files#diff-4) (44)

M images/screenshot.png ( https://github.com/therecluse26/PHP-Login/pull/238/files#diff-5) (0)

M index.php ( https://github.com/therecluse26/PHP-Login/pull/238/files#diff-6) (3)

A js/create.js ( https://github.com/therecluse26/PHP-Login/pull/238/files#diff-7) (45)

M main_login.php ( https://github.com/therecluse26/PHP-Login/pull/238/files#diff-8) (91)

Patch Links:

https://github.com/therecluse26/PHP-Login/pull/238.patch

https://github.com/therecluse26/PHP-Login/pull/238.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/therecluse26/PHP-Login/pull/238?email_source=notifications&email_token=AB63QARLB2BE3N2R53PFKQDQIQNY3A5CNFSM4IURLYP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJ7HMGQ), or mute the thread ( https://github.com/notifications/unsubscribe-auth/AB63QAU3C24JETKYXYVF7DTQIQNY3ANCNFSM4IURLYPQ ).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/therecluse26/PHP-Login/pull/238?email_source=notifications&email_token=AEZ7HSCDTKGLUS4EZJHV7UTQIQOUPA5CNFSM4IURLYP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FC4UI#issuecomment-529149521, or mute the thread https://github.com/notifications/unsubscribe-auth/AEZ7HSHJHKHJQUBUGO5IQN3QIQOUPANCNFSM4IURLYPQ .

therecluse26 commented 5 years ago

It's not, but thank you. It hasn't used mysql_connect for like 5 years when I took it over and refactored it to use PDO. It even says PDO in the first sentence of the README.

It looks like you're pushing changes to a version from when this library was first conceived. It's completely different now.