search

theredditbandit / pman

A CLI project manager
Other
37 stars 4 forks source link

package db tests #23

Closed yannick2009 closed 5 months ago

yannick2009 commented 5 months ago

Launch go test -cover ./... to run the tests and see the percentage of coverage.

ccoVeille commented 5 months ago

I would ask you to wait before https://github.com/theredditbandit/pman/pull/27 to be merged if you are OK guys

it would report CI errors on your code

ccoVeille commented 5 months ago

@theredditbandit you asked me to review, but I will wait for the CI changes to be rebased in this branch, so we could see what the CI will report

ccoVeille commented 5 months ago

I will need to be in front of a computer to review in details, but I'm impressed by the changes you made @yannick2009

theredditbandit commented 5 months ago

@ccoVeille can you figure out why ci is breaking , I can't make sense of the error message.

theredditbandit commented 5 months ago

Finally all checks pass! 🎉

To get rid of the error I had to run 

gci write -s standard -s default -s 'prefix(github.com/theredditbandit/pman)' .

to format it like golangci-lint likes it

@ccoVeille did you have any thoughts on these changes