search

theredguild / devcontainer

The Red Guild's devcontainer focused in web3 and security.
26 stars 20 forks source link

Fix medusa installation using multi-stage build #7

Closed EperezOk closed 2 weeks ago

EperezOk commented 1 month ago

In the current version of the Dockerfile, medusa is not being installed.

This PR installs medusa using a multi-stage build. This way, the go installation can be removed from the main container.

mattaereal commented 1 month ago

Isn't it installed by crytic-compile? I'm pretty sure I checked this on my tests. Maybe I forgot to add pipx install medusa?

EperezOk commented 1 month ago

From the docs and my tests, I'm 98% sure it's neither installed by crytic-compile nor available through pipx.

mattaereal commented 2 weeks ago

Thanks for the contribution, and I will look into it, but the way you suggested is not the way we would like to accomplish this.

You're deleting asdf installation among other things. I'll add an issue to address this in the future.

Thanks again <3