search

therezacuet / Motion-Tab-Bar

A beautiful animated flutter widget package library. The tab bar will attempt to use your current theme out of the box, however you may want to theme it.
MIT License
293 stars 74 forks source link

Runtime Bug Fix #33

Closed theHamdiz closed 6 months ago

theHamdiz commented 6 months ago

Fixed the runtime bug that caused any app using the motion bar to crash because of accessing late variables before initializing them.

therezacuet commented 6 months ago

@theHamdiz I have gone through your PR and found lots of unnecessary changes. The solution to this run time error issue was very simple( just change a single line of code and rearrange). I found you have a duplication of the same code. For this reason, I am declining this PR. But thanks for your effort. I appreciate it. You may go through new release to find out the solution.

theHamdiz commented 4 months ago

Much appreciated I don't really mind as long as it's fixed.

On Thu, Jan 4, 2024 at 1:04 PM Rezaul Islam @.***> wrote:

@theHamdiz https://github.com/theHamdiz I have gone through your PR and found lots of unnecessary changes. The solution to this run time error issue was very simple( just change a single line of code and rearrange). I found you have a duplication of the same code. For this reason, I am declining this PR. But thanks for your effort. I appreciate it. You may go through new release to find out the solution.

— Reply to this email directly, view it on GitHub https://github.com/therezacuet/Motion-Tab-Bar/pull/33#issuecomment-1876824692, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABS5RCAV4322LMEJDYAPY4DYMZ5DTAVCNFSM6AAAAABBDQD7QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZWHAZDINRZGI . You are receiving this because you were mentioned.Message ID: @.***>