search

theriley106 / SneakerBotTutorials

Open Source SneakerBot created as a supplement to my "Creating a Sneaker Bot in Python" Youtube Series
https://www.youtube.com/playlist?list=PL3fpqcQTK0f9sACDQstvjxbHzD1L_gr__
MIT License
621 stars 137 forks source link

Added lxml to requirements #15

Closed moose99 closed 3 months ago

moose99 commented 6 years ago

Added lxml requirement, since it is used as the bs parser in app.py:getCommits(). Otherwise if you don't have lxml installed, that func will fail and throw an exception, resulting in no git commits showing up.

Another option would be just to remove lxml and just use the builtin default html parser in BeautifulSoup

kjloveless commented 5 years ago

Looks good to me.

sorenrood commented 3 years ago

I know this is 3 years old but I'm reviewing the PR. If LXML is used, it should be added to requirements.txt.