Localization of loch.app on macOS platform

therion / therion

therion – cave surveying software

https://therion.speleo.sk

GNU General Public License v2.0

94 stars 44 forks source link

Open ladislavb opened 2 years ago

ladislavb commented 2 years ago

Not sure if Loch UI localization ever worked on macOS but I just noticed that locales are not included in the loch.app app bundle. Typically these files should be included in Resources folder - see https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFBundles/BundleTypes/BundleTypes.html#//apple_ref/doc/uid/10000123i-CH101-SW1. This is a low priority issue, I will try to investigate further...

Afforix commented 2 years ago

I'll try to make necessary changes in the CMake scripts.

Afforix commented 2 years ago

Can you please test my branch https://github.com/Afforix/therion/tree/macos-locale? What it installs can be seen at https://github.com/Afforix/therion/runs/5858340470?check_suite_focus=true#step:7:11. I don't know if the subdirectory LC_MESSAGES is necessary, currently it is not there.

ladislavb commented 1 year ago

Sorry, totally missed your response. Was this change already merged into upstream repository or should I still try with your branch? Thanks.

Afforix commented 1 year ago

Hi, it is still not merged, we don't have Apple hardware for testing. I have updated the branch with the latest master, you can test it.

Afforix commented 1 year ago

I have created pull request #489 to better track the changes.