search

theripper93 / Smart-Target

A module to target with Alt+Click and show portraits instead of colored pips to indicate targets
GNU General Public License v3.0
15 stars 10 forks source link

Bug fix for "As GM target indicator is avatar instead of selected token" #18

Closed p4535992 closed 3 years ago

p4535992 commented 3 years ago

This pull request shoul be a fix for the Bug As GM target indicator is avatar instead of selected token issue.

There are two cons though:

1) to pass the information about the token image I had to use an additional mechanism in this case the flags (perhaps a solution with sockets could be more efficient in the future) 2) To maintain backward compatibility with 0.7 I used the deprecated method of setting flags on the 'data' object instead on the document, this may also need to be fixed in the future, but I don't think 0.9.0 will arrive anytime soon, so several warning logs will appear on the console of the type:

foundry.js:19277 You are calling PlaceableObject#unsetFlag which has been deprecated in favor of Document#unsetFlag. Support will be removed in 0.9.0

Make some test seem to work.

If, on the other hand, you have suggestions or tricks that you want me to integrate let me know. Greeting.

p4535992 commented 3 years ago

I will reopen this pull when (or if ) i resolved the issue.