theripper93 / wall-height

GNU General Public License v3.0
3 stars 6 forks source link

Cannot move over wall when vaulting is disabled, and token elevation is equal to the wall height. #12

Closed cs96and closed 2 years ago

cs96and commented 2 years ago
  1. Disable vaulting.
  2. Create a wall with a height of 20ft.
  3. Set a token to an elevation of 20ft
  4. Try to move the token over the wall using the cursor keys. The token will not be able to move past the wall.
  5. Set the token elevation to 20.01. The token can now move over the wall.
theripper93 commented 2 years ago

This is intentional as you can read from the change log, the behavior has been changed from the previous version of wall height, if your maps relied on exact numbers there is a macro to -1 all the walls in the map

cs96and commented 2 years ago

I looked at the changelog and can't see anything related to being at the same height as the top of a wall.

I'm not migrating, this is a new module install for me. In my head it makes sense that you can walk over a wall with top height 10ft, if my feet are at 10ft.

theripper93 commented 2 years ago

It’s in the readme under breaking change my bad, anyways you are free to keep using the old version if you want Remember to also downgrade and don’t update modules such as levels, better roofs, perfect vision and possibly more

cs96and commented 2 years ago

The breaking change says...

The Top of walls is now included in vision blocking calculations

I'm not talking about vision calculation, I'm talking about moving. The token can see over the wall (because the bottom of the token is the same height as the top of the wall), but it is unable to move over it.

theripper93 commented 2 years ago

I’ll correct it it make it more clear, but it blocks both

cs96and commented 2 years ago

But the vision is not being blocked in my case. I can see over the wall, but can't move over it. That seems incorrect to me.

theripper93 commented 2 years ago

That’s because of token height , check that section of the readme, if you want you can customize it such that you have the old behavior (eg younset the global height to 1 and disable the auto height in the module setting )

cs96and commented 2 years ago

The token height should have no effect. My token is at elevation 20ft. That means its feet are 20ft off the ground and can therefore step over a 20ft wall, The height of my token is irrelevant at that point.

cs96and commented 2 years ago

Basically, you just need to change a > to a >= somewhere in your code.

theripper93 commented 2 years ago

No it can’t, a 20 ft top wall will block movement of a 20 elevation token unless you enable vaulting

cs96and commented 2 years ago

Yes but my point is that it shouldn't. It's no different to walking on the floor, which has elevation zero, and the token would also have elevation zero.

theripper93 commented 2 years ago

It was decided to make not work like that for some new features to play nice together we can agree to disagree but it’s not gonna change. And also I provided you with multiple solutions to have it work the way you want , not sure what more I can do