theripper93 / wall-height

GNU General Public License v3.0
3 stars 8 forks source link

Doors detected as walls when above 27ft when Wall-Height is used alongside Levels #20

Closed SaintBalor closed 2 years ago

SaintBalor commented 2 years ago

ALL OTHER MODULES DISABLED? false Module: Wall Height 4.7.1 Conflicting Module (if applicable): Levels 3.1 Foundry and System version: eg. Foundry V10 - Build 284 / D&D5E 2.0.2 OS, Hosting, Browser (if applicable): Noticed while Hosting - Replicated in OS for testing purposes Short Description of bug: Doors are detected as walls when bottom height or token are 27ft or above, when Wall-Height is used alongside Levels. Players cannot open doors above those levels Simple steps to reproduce the bug:

Screenshots and/or console errors:

Initial test setup (noticed the issue happening initially at 30 ft height) Test Setup

With both Levels and Wall Height (and dependencies) turned on: With Levels On

Levels - On / wall Heights - Off: Wall Height Disabled

Levels - Off / Wall Heights - On: Without Levels on

Levels and Wall Heights - On / 26ft: 26test2

Levels and Wall Heights - On / 27ft: 27test2

theripper93 commented 2 years ago

This is a very weird issue, i don't see a reason for the height to matter, nor a reason for Levels altering the door behaviour (since there is no code for that). I suspect this is related to a core door bug, an update to foundry v10 is coming out soon, can you update me if that fixes the issue for you? As it stands i cannot reproduce this issue with the steps provided.

SaintBalor commented 2 years ago

Huh, Interesting... Will do! I'll also try other things like using a new world instead of a converted one to see if maybe that's a factor, but hopefully the update will fix that bug though. Thanks!

SaintBalor commented 2 years ago

I've had a chance to test it in Foundry V10 - 285 to the same results Here are the steps I took to reproduce the issue:

  1. Performed clean installation of latest Foundry Version and installed Levels, libWrappper and Wall Height modules
  2. Created new world "testworld". Set System to 5E
  3. Logged in as Gamemaster
  4. Created new scene - "testscene" with Fog of War exploration
  5. Created new actor - "testactor" and enabled 30ft vision in Prototype Token
  6. Enabled Levels, libWrapper and Wall Height modules
  7. Activated testscene
  8. Placed "testactor" token on map inside testscene
  9. Set testactor elevation to 27ft
  10. Placed door in scene - set bottom height to 27/ set top height to 37
  11. Clicked on token to view from its perspective

New pictures: newtest2

newtest

Hopefully these revised steps help replicate the issue, but if you need it, I can zip and attach the new world file I created. It has no assets, and only those three modules active.

theripper93 commented 2 years ago

Ok, with from scratch steps I might be able to repro

theripper93 commented 2 years ago

image image

Followed all the steps, cannot replicate the issue, at this point i'm really not sure what to do with this... beeing specific to 27 also makes no sense. Sorry but i'll close this issue for now, i have no clue what is going on, but i'll keep my eyes open if this arises again.