search

thermatk / FakeGApps

A better approach for microg
GNU General Public License v3.0
227 stars 48 forks source link

Please add README.md #2

Closed IzzySoft closed 9 years ago

IzzySoft commented 9 years ago

Could you please add at least a basic README.md to this project, explaining

Without knowing what it's for, it's hard to tell whether that's what one needs. In my case, I need something making UnifiedNlp work on a device with stock ROM (or course having GApps pre-installed), where XposedUnifiedNlp obviously doesn't do that job. Would your module be of help here? Hard to tell without some basic info :innocent:

Btw: Will you upload your module to the Xposed repo?

bonanza123 commented 9 years ago

I added a preliminary readme to my fork: https://github.com/bonanza123/FakeGApps

IzzySoft commented 9 years ago

Thanks a lot, @bonanza123 – I see you've even included it with your pull request, great! Finally something for starters to follow :thumbsup:

thermatk commented 9 years ago

Merged It's great to see that my idea is used, didn't really expect it after the initial skepticism :)

IzzySoft commented 9 years ago

Thanks a lot, @thermatk – that just leaves the question with the Xposed repo open :stuck_out_tongue_winking_eye:

bonanza123 commented 9 years ago

I'm actually not sure whether this is needed. I currently don't think that any further changes to this module are needed, which maybe makes the advantages of easy updating via Xposed Installer obsolete.

julienschmidt commented 9 years ago

It would also make it easier for people to discover this module (and µg). And if there might be an update necessary in the future, it certainly doesn't hurt to have it in the repo :wink:

IzzySoft commented 9 years ago

I agree with @julienschmidt here. Not everyone will search Github for modules. First place for most people certainly is the repo (after Playstore, maybe). There then should be a link pointing here, especially for any possible issues.