thermocycle / Thermocycle-library

Thermocycle library
http://thermocycle.squoilin.eu
MIT License
55 stars 24 forks source link

Error in Tank_pL allows for larger volumes than total volume and relative level above 1 #36

Open emontanus opened 7 years ago

emontanus commented 7 years ago

The relative level inside the tank is not constrained between 0 and 1 as intended. When the level increase above 1 it results in both the density and the volumes of the tank to take values which should not be possible.

This results in a slower pressure increase in systems, includig the tank_pl, as the tank can absorb more liquid than dimensioned and the density becomes very high.

To see the problem run the example "ORC_245faInc" for 100 seconds, the boundaries of the level and the volumes are violated at around 25 seconds.