search

thermondo / closeio

(deprecated/unused) A small API library to access close.io CRM
Other
3 stars 1 forks source link

Replace stale .next() in testing stub and update create_export stub with missing fields #122

Closed amureki closed 6 years ago

amureki commented 6 years ago
  1. Since Python 3.2 next(generator) should be used instead of generator.next()
  2. create_lead_export stub was missing status and download_url fields. https://developer.close.io/#exports
codecov[bot] commented 6 years ago

Codecov Report

Merging #122 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   41.17%   41.17%           
=======================================
  Files           9        9           
  Lines         782      782           
=======================================
  Hits          322      322           
  Misses        460      460
Impacted Files Coverage Δ
closeio/contrib/testing_stub.py 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f53575f...86c0ebb. Read the comment docs.

amureki commented 6 years ago

@codingjoe can you, please, check this one? It is preventing me from writing some tests in our system. :)

amureki commented 6 years ago

@mostafa-anm Hey! I am assigning you since Johannes is not available. :(

amureki commented 6 years ago

@codingjoe @mostafa-anm hi, can you check this one? :)

mostafa-anm commented 6 years ago

@amureki Looks good, feel free to merge when you need it.

amureki commented 6 years ago

Thank you! 🎉 Released in 1.0.1