search

thermondo / closeio

(deprecated/unused) A small API library to access close.io CRM
Other
3 stars 1 forks source link

Add ORGANIZATION_ID setting to prevent requests being sent from wrong organization #124

Closed amureki closed 6 years ago

amureki commented 6 years ago

This PR adds extra check to a webhook handler to check an organization id. If it does not match the setting, we just respond without any action.

codecov[bot] commented 6 years ago

Codecov Report

Merging #124 into master will increase coverage by 0.88%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   41.22%   42.11%   +0.88%     
==========================================
  Files           9       10       +1     
  Lines         781      793      +12     
==========================================
+ Hits          322      334      +12     
  Misses        459      459
Impacted Files Coverage Δ
closeio/conf.py 100% <100%> (ø)
closeio/contrib/django/views.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72a5b62...717ea52. Read the comment docs.

amureki commented 6 years ago

@codingjoe this one is not a blocker for Checkpoint-Charlie project, but might be helpful there. Could you, please, check and give your thoughts on this?

amureki commented 6 years ago

Not needed for now. I will reopen this later if requested.