search

thermondo / closeio

(deprecated/unused) A small API library to access close.io CRM
Other
3 stars 1 forks source link

install always correct django version on travis #132

Closed anneFly closed 5 years ago

anneFly commented 5 years ago

131 added Django to our dev requirements. In travis we want test against different Django versions, and this change actually broke that because when installing Django there, the requirement was already satisfied from requirements_dev.txt.

This PR makes sure that the correct django version is installed on travis.

codecov[bot] commented 5 years ago

Codecov Report

Merging #132 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   41.06%   41.06%           
=======================================
  Files           9        9           
  Lines         823      823           
=======================================
  Hits          338      338           
  Misses        485      485

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1bc1d72...feb0e86. Read the comment docs.

codingjoe commented 5 years ago

It would be actually enough for this package to only test the latest version.

anneFly commented 5 years ago

@codingjoe

You can add Django to the requirements.txt file with Django>=1.11.

Django is not a dependency for this package, so there is no need to add it here. It is only needed for running all tests. So it is a dev requirement imho.

It would be actually enough for this package to only test the latest version.

you mean the latest stable version, right? Sure, I can do that. Then I would make a PR with removing the extra versions from travis config.