search

thermondo / closeio

(deprecated/unused) A small API library to access close.io CRM
Other
3 stars 1 forks source link

fix return value in testing stub for creating activities #136

Closed anneFly closed 5 years ago

anneFly commented 5 years ago

When creating activities like notes or calls, the API returns the data of the created activity, just like it's documented here. This library returns the response correctly but the testing stub did not return anything and therefore was not reflecting the behaviour of the library. This PR fixes this and adds some tests for this case.

codecov[bot] commented 5 years ago

Codecov Report

Merging #136 into master will increase coverage by 2.92%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   53.84%   56.77%   +2.92%     
==========================================
  Files           9        9              
  Lines         884      886       +2     
==========================================
+ Hits          476      503      +27     
+ Misses        408      383      -25
Impacted Files Coverage Δ
closeio/contrib/testing_stub.py 38.28% <100%> (+6.86%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1be6b3d...25f0350. Read the comment docs.