thermondo / closeio

(deprecated/unused) A small API library to access close.io CRM
Other
3 stars 1 forks source link

django-model #2

Closed codingjoe closed 10 years ago

codingjoe commented 10 years ago

Adds a new Django model, that maps CloseIO to Django fields. It includes a separate manager and pseudo decorators for field mapping as well as mapping functions.

codingjoe commented 10 years ago

@syphar tests are still missing. Do you have is there a good way to test the model without mocking the underlying API?

syphar commented 10 years ago

@codingjoe like django itself does tests. By just creating a small app that is tested then.

See https://github.com/django/django/tree/master/tests/choices https://github.com/django/django/blob/master/tests/runtests.py

codingjoe commented 10 years ago

But against which backend?

syphar commented 10 years ago

either a test-backend

or mock the calls (with mock, the pytest monkeypatch or httpretty)

syphar commented 10 years ago

In general,

seperate commits for seperate features ...

syphar commented 10 years ago

but we'll keep it for now

syphar commented 10 years ago

I you split the signal-part (which seems nearly finished) and the tests for it, we can merge this part @codingjoe

syphar commented 10 years ago

closing (unmerged) because of problems that arose