thermondo / closeio

(deprecated/unused) A small API library to access close.io CRM
Other
3 stars 1 forks source link

add due_date__lte argument to get_tasks #3

Closed brillout closed 10 years ago

brillout commented 10 years ago

@syphar I haven't found any corresponding tests

codingjoe commented 10 years ago

as said earlier, id go with kwargs and parse all instances of date or datetime

brillout commented 10 years ago

@codingjoe My thought was; either support all arguments or only add the one I need. For code pace sake I decided the later one. I'm ok with supporting all arguments though.

codingjoe commented 10 years ago

I'd say supporting all arguments of a similar data type should be fine. Other arguments might not need casting. There is actually a method, that handles all the casting. You can simply add kwargs cast them and you'll automatically support all filters.

brillout commented 10 years ago

@codingjoe nice & generic now ;D @syphar all ok for you?

brillout commented 10 years ago

note that beacuse of **kwargs the changes are not backward compatible. @syphar Am I correct to assume that we are the only ones using this package?

syphar commented 10 years ago

yes

syphar commented 10 years ago

merged in 5baccef357cbaecd372e0335dfbe4f89e69d695e