thermondo / pytest-translations

test translation files with pytest
Other
17 stars 3 forks source link

Adds spell checking #4

Closed codingjoe closed 8 years ago

codingjoe commented 8 years ago

What this PR adds:

syphar commented 8 years ago
syphar commented 8 years ago
codingjoe commented 8 years ago

Ok, I should have caught all your comments.

codingjoe commented 8 years ago

The dicts for multiple languages are still missing.

codingjoe commented 8 years ago

@syphar I added multiple language support for private word lists and python format string chunkers. Ready when you are :)

syphar commented 8 years ago

I also see

SKIP [5] ~/src/pytest-translations/pytest_translations.py:322: Dictionary "" not found.

Reason was that the Language attribute in some of the .po files was missing.

I think we should fail in that case. Or assume english. But I tend to fail.

syphar commented 8 years ago

@codingjoe you can have a first look

normansander commented 8 years ago

A description would be helpful

syphar commented 8 years ago

@headione you mean about what the PR should change / do? or general documentation?

normansander commented 8 years ago

yes @syphar, i was missing a little description in this pull request and its impacts. for me it was a bit hard to understand the feature without it, although it has a precise title. but other than that LGTM 👍🏼

syphar commented 8 years ago

@headione added a description

codingjoe commented 8 years ago

@syphar I'm happy except the missing new line? Is there anything you'd like to add before I merge?

syphar commented 8 years ago

@codingjoe newline fixed.

If you tested and everything is fine, feel free to merge