Closed codingjoe closed 8 years ago
Ok, I should have caught all your comments.
The dicts for multiple languages are still missing.
@syphar I added multiple language support for private word lists and python format string chunkers. Ready when you are :)
I also see
SKIP [5] ~/src/pytest-translations/pytest_translations.py:322: Dictionary "" not found.
Reason was that the Language
attribute in some of the .po
files was missing.
I think we should fail in that case. Or assume english. But I tend to fail.
@codingjoe you can have a first look
A description would be helpful
@headione you mean about what the PR should change / do? or general documentation?
yes @syphar, i was missing a little description in this pull request and its impacts. for me it was a bit hard to understand the feature without it, although it has a precise title. but other than that LGTM 👍🏼
@headione added a description
@syphar I'm happy except the missing new line? Is there anything you'd like to add before I merge?
@codingjoe newline fixed.
If you tested and everything is fine, feel free to merge
What this PR adds: