Remove everything between %( and ).

thermondo / pytest-translations

test translation files with pytest

Other

17 stars 3 forks source link

Remove everything between %( and ). #42

Open svengt opened 5 years ago

svengt commented 5 years ago

Should't this line be text = re.sub('\%\(.*?\)s?', '', text) https://github.com/Thermondo/pytest-translations/blob/master/pytest_translations/po_spelling.py#L82, or something in that direction?

We're getting spelling failures on words like ss. This happens when you have two format variables right next to each other. For example: 'this is a %(test1)s%(test2)s'.

codingjoe commented 5 years ago

Hi @svengt! Thanks for reaching out. We actually don't use the library that much anymore, we switched to msgcheck. That being said, I would be delighted if you can provide a patch to resolve the issue. We also did some similar improvements on msgcheck, especially when it comes to parsing. Maybe they can serve as reference to work on a patch. Best -Joe

svengt commented 5 years ago

@codingjoe Thank you for your quick reply. I was not aware of the package msgcheck, thanks for pointing that out. We will try that first, see if it fits our needs. 👍

codingjoe commented 5 years ago

👌