search

thermondo / pytest-translations

test translation files with pytest
Other
17 stars 3 forks source link

test_translations.py: Add . to ext #48

Closed jayvdb closed 3 years ago

jayvdb commented 3 years ago

Fixes https://github.com/Thermondo/pytest-translations/issues/47

codecov[bot] commented 3 years ago

Codecov Report

Merging #48 (cf4626a) into master (e37d863) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files           6        6           
  Lines         187      187           
=======================================
  Hits          176      176           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e37d863...cf4626a. Read the comment docs.

syphar commented 3 years ago

@jayvdb thanks for your contribution! Didn't know there were more users of this library :) (but we are still using it, so it's maintained).

I'll be able to look into the issue and the PR some time in the next days and will comment in more detail.

syphar commented 3 years ago

@jayvdb now I came to it.

Thanks for the fix for the problem.

First I was confused why this slipped my own tests, then I saw that it only started breaking with pytest 6.2.

I'll add more explicit testing in another branch.