theroyallab / tabbyAPI

An OAI compatible exllamav2 API that's both lightweight and fast
GNU Affero General Public License v3.0
440 stars 64 forks source link

[REQUEST] GitHub Actions for Multi-Architecture Docker Image Builds #157

Closed 0x4139 closed 1 week ago

0x4139 commented 1 month ago

Proposal:

Is your feature request related to a problem? Please describe.

Currently, the project does not have automated workflows for building Docker images for multiple architectures. This limitation causes frustration when trying to support diverse deployment environments, leading to manual builds and potential inconsistencies.

Describe the solution you'd like

I propose adding GitHub Actions workflows to automate the building and pushing of Docker images for various architectures (e.g., x86, ARM). This will streamline our CI/CD pipeline, ensuring consistent and reliable builds across different platforms.

Describe alternatives you've considered

Why should this feature be added?

Examples

Additional context

Here is an example of the GitHub Actions workflow that can be added:

name: Build and Push Docker Images

on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
    - name: Checkout code
      uses: actions/checkout@v2

    - name: Set up Docker Buildx
      uses: docker/setup-buildx-action@v1

    - name: Login to Docker Hub
      uses: docker/login-action@v1
      with:
        username: ${{ secrets.DOCKER_USERNAME }}
        password: ${{ secrets.DOCKER_PASSWORD }}

    - name: Build and push Docker images
      uses: docker/build-push-action@v2
      with:
        context: .
        push: true
        platforms: linux/amd64,linux/arm64
        tags: user/repo:latest

Thank you for considering this proposal. Please feel free to reach out for any clarifications or further discussions, I am more than happy to submit a pull request.


bdashore3 commented 1 month ago

Can be linked to #123. A pull request would be helpful since I don't use docker.

bdashore3 commented 1 week ago

Resolved via #171