search

therufa / mdi-vue

Material design icons for vue.js
https://www.npmjs.com/package/mdi-vue
MIT License
88 stars 13 forks source link

The generated components have a "view-box" attribute, which should be "viewBox" #2

Closed robcresswell closed 7 years ago

robcresswell commented 7 years ago

As in the title, the attribute added to the generated components appears to be incorrect.

robcresswell commented 7 years ago

Specifically, this like is wrong, I think: https://github.com/therufa/mdi-vue/blob/c4e57ad3c7c4c69d3cd59417054969fea8d2a0ee/build.tpl#L4

It should be "viewBox" instead of "view-box". If you load this in a browser and change them, you'll see the icon change size as the viewBox takes effect.

therufa commented 7 years ago

Thank you for your time. ill evaluate this and get back to it.

robcresswell commented 7 years ago

Thanks so much! You can see more about it here: https://developer.mozilla.org/en/docs/Web/SVG/Attribute/viewBox

It'd be great to see this fixed, because it makes it very difficult to properly scale these icons otherwise.

therufa commented 7 years ago

@robcresswell i believe this is fixed now. i just published the fix a few minutes ago. i hope it will work fine