search

therufa / mdi-vue

Material design icons for vue.js
https://www.npmjs.com/package/mdi-vue
MIT License
88 stars 13 forks source link

SVG <title> suggestion #27

Closed josephfh closed 5 years ago

josephfh commented 5 years ago

The svgs inside each icon's vue components have a title attribute: <title>MDI instagram</title>

I'd like to use these icons inside a link, without the SVG title being used by the browser. I.e. <a href="#" title="Inbox"><email-icon /></a>

Seeing as the icon name is unlikely to be the best wording, it might be better to omit the attribute from the svg altogether.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/josephfh"><img src="https://avatars.githubusercontent.com/u/889121?v=4" />josephfh</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>Pull request for your consideration: <a href="https://github.com/therufa/mdi-vue/pull/28">https://github.com/therufa/mdi-vue/pull/28</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/therufa"><img src="https://avatars.githubusercontent.com/u/315825?v=4" />therufa</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>Thanks for the input. I merged this by accident though, because the user should have the option to add titles if required. Anyways! Thanks for the changes! They'll be out tomorrow.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>