search

therufa / mdi-vue

Material design icons for vue.js
https://www.npmjs.com/package/mdi-vue
MIT License
88 stars 13 forks source link

Link to icons.css from template #35

Closed chriscalo closed 4 years ago

chriscalo commented 4 years ago

I feel like icons should render at the correct size by default without devs having to do anything additional, so this PR links icons.css to all icon components.

I did not test this, and instead wanted to get a read on whether you're open to a change like this before putting much effort into it. I have no idea what the possible downsides and complications of a change like this are (will all build systems correctly handle this?), so feel free to reject this if there are concerns. I didn't spend a lot of time on it.

therufa commented 4 years ago

Hi @chriscalo, i'd like to give this a try, but i want to test it first. I'll come back to you on this, because I agree on what you're saying regarding the extra work.
Right now I don't know how this will affect our current package. I hope it turns out as I expect it. Thanks so much for your contributions btw! You're awesome 💪

therufa commented 4 years ago

hi @chriscalo , i've tested this and it seems to be working. Should be out now with version 1.4.6.

chriscalo commented 4 years ago

Right on, thanks so much for testing it out and merging 👍