search

therufa / mdi-vue

Material design icons for vue.js
https://www.npmjs.com/package/mdi-vue
MIT License
88 stars 13 forks source link

Quick README fix and Hack proposal to identify which vuejs version is in use #51

Closed philippedasilva-orizone closed 3 years ago

philippedasilva-orizone commented 3 years ago

Hi,

I first saw a simple omission in the README.md file that I thought should be fixed. Otherwise, this pull request is mainly targeting to hack around vuejs version detection at runtime which, for some unknown reason, doesn't seem like an easy task...

The actual "hack" consists on looking on the version of the `node_modules/vue/package.json' file and use it to avoid the ReferenceError we get when using Vue 3 on the master branch at the time of this pull request. I refer to #50 ;)

Not the most elegant but it works. Up to you now ;)

therufa commented 3 years ago

Hi @philippedasilva-orizone, Thanks for the PR, in the meantime i've fixed the issue but forgot to publish the changes. I still merged the update on the README. Many thanks for participating 🙌

philippedasilva-orizone commented 3 years ago

You're welcome ;) I'll give a try and feedback if any