therufa / mdi-vue

Material design icons for vue.js
https://www.npmjs.com/package/mdi-vue
MIT License
88 stars 13 forks source link

Throws warnings for width/height props with units #7

Closed DDeBruler closed 6 years ago

DDeBruler commented 6 years ago

Both the width and height attributes of <svg> elements can properly be specified as length or percentage content types. The generated components pass any specified values along to the rendered SVG, which then displays at the appropriate size, but if the specified values include units (e.g. 1em, 12px, etc.), the component logs a warning to the console:

[Vue warn]: Invalid prop: type check failed for prop "height". Expected Number, got String.
therufa commented 6 years ago

This should be fixed with the new release. Thanks for your efforts!