therungg / therun-frontend

Frontend for therun.gg
https://therun-fr-therun.vercel.app
MIT License
23 stars 8 forks source link

[Fix] Inconsistent number formatting for big numbers #260

Closed abhinavk454 closed 1 month ago

abhinavk454 commented 2 months ago

257

florence-wolfe commented 2 months ago

There's a number of components and files that haven't been addressed at all — Uncertain if this was intentional or an oversight. For example, here's a few I found very quickly:

To that same point, not all uses of DurationToFormatted have the padded attribute.

abhinavk454 commented 1 month ago

Screenshots

Screenshot 2024-06-19 193212

Screenshot 2024-06-19 193605

Screenshot 2024-06-19 202018

Screenshot 2024-06-19 202033

Screenshot 2024-06-19 202251

image

Screenshot 2024-06-19 202111

florence-wolfe commented 1 month ago

@abhinavk454 Is this PR still a WIP? I noticed that the number formatting utility is removed and all occurrences were as well. If we're no longer aiming to localize and format numbers can we rename this PR and change its scope for other reviewers

therungg commented 1 month ago

Closing this PR for the following reasons:

It's better if this issue is handled by someone who is more familiar with the project and the full codebase. If you want to learn about the project and join our community, feel free to join our Discord and get to know us!