therungg / therun-frontend

Frontend for therun.gg

https://therun-fr-therun.vercel.app

MIT License

27 stars 9 forks source link

[Fix] Inconsistent number formatting for big numbers #260

Closed abhinavk454 closed 5 months ago

abhinavk454 commented 5 months ago

257

florence-wolfe commented 5 months ago

There's a number of components and files that haven't been addressed at all — Uncertain if this was intentional or an oversight. For example, here's a few I found very quickly:

golds.tsx
history.tsx
wr-history.tsx
tournament-stats.tsx
tournament-runs.tsx

To that same point, not all uses of DurationToFormatted have the padded attribute.

Could we get some screenshots on the changes since this should have visual impact for users. Especially for certain languages numbers will be formatted and take up much horizontal space which could cause some possible issues @zoglo

abhinavk454 commented 5 months ago

Screenshots

Screenshot 2024-06-19 193212

Screenshot 2024-06-19 193605

Screenshot 2024-06-19 202018

Screenshot 2024-06-19 202033

Screenshot 2024-06-19 202251

Screenshot 2024-06-19 202111

florence-wolfe commented 5 months ago

@abhinavk454 Is this PR still a WIP? I noticed that the number formatting utility is removed and all occurrences were as well. If we're no longer aiming to localize and format numbers can we rename this PR and change its scope for other reviewers

therungg commented 5 months ago

Closing this PR for the following reasons:

package.json is adjusted, not part of the issue
package.lock is adjusted, not part of the issue
Calls to DurationToFormatted are adjusted, not part of the issue and unwanted
Many numbers that need to be formatted are not
Numbers that should not be formatted are formatted

It's better if this issue is handled by someone who is more familiar with the project and the full codebase. If you want to learn about the project and join our community, feel free to join our Discord and get to know us!