therungg / therun-frontend

Frontend for therun.gg
https://therun-fr-therun.vercel.app
MIT License
23 stars 8 forks source link

Rewrite global search component #266

Closed florence-wolfe closed 1 month ago

florence-wolfe commented 1 month ago

Rewrote the search component.

https://www.loom.com/share/82b2da68e0bf466d88e04a797efa4e83?sid=0cf0c4d3-f5fe-448b-be5a-c5d615578661

image image

Related to #4

zoglo commented 1 month ago

@florence-wolfe

I did a few changes in 3370d1dbbe217917972030bdbf5d49b5117e68eb

  1. I used description lists rather than abusing the list-group-item from bootstrap to correctly distinguish between games and users
  2. I completely dropped the inline-styles, we don't need them as we already had the input-group + dropdown-menu-combo before. All of your custom classes and inline-styles ain't needed, they are provided by Boostrap.
  3. I introduced the bootstrap utilities last year for stuff like min/max width/height and whatever <3 - I made sure to add the max-height of 400px into that
zoglo commented 1 month ago

Thank you @florence-wolfe <3