Closed dotneB closed 1 year ago
@dotneB is attempting to deploy a commit to the therun Team on Vercel.
A member of the Team first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
therun-fr | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 17, 2023 4:43am |
Should the EDGE_CONFIG
be set in the default .env
, or should it only exist in PROD?
I would prefer having all possible env variables in the default .env
, to avoid confusion. If it shouldn't be used in local, it should have a value that indicates that, but still be present imo.
Should the
EDGE_CONFIG
be set in the default.env
, or should it only exist in PROD?I would prefer having all possible env variables in the default
.env
, to avoid confusion. If it shouldn't be used in local, it should have a value that indicates that, but still be present imo.
There are limits/cost to having Edge Configs on vercel, so that's the only reason why I could see not wanting to expose it to local. Because of the number of refreshes and tests we do. And since there are limits and cost, I prefer assuming this doesn't need to be activated to function, that's why it falls back to using Env variables.
But I added it to the default .env and handle the case where it's an empty string as disabled.
Merged, thanks so much, @dotneB!
EDGE_CONFIG
is presentNote: Variables are prefixed by
FEATURE_FLAGS_
(ex:FEATURE_FLAGS_MAINTENANCE_MODE
) See #10