therungg / therun-frontend

Frontend for therun.gg
https://therun-fr-therun.vercel.app
MIT License
26 stars 8 forks source link

[Bugfix] Fixed an issue with skeleton animations throwing an error #32

Closed zoglo closed 1 year ago

zoglo commented 1 year ago

@therungg

This should fix the skeleton animation throwing an error within console

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
therun-fr ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 6:40pm
zoglo commented 1 year ago

Good point, might just need to remove the outer div @francis-robert .

Will do it soon.

Also no need on the viewbox itself as the SVG gets inline styles itself. Having the viewbox would make it non-responsive again.

therungg commented 1 year ago

This still gives some of the console errors as per the latest deployment. It's from the calc()'s.

image

Also, seems to still not render correctly there. Looks like (not coincidentally) it renders it at 100px height. Is this different on windows/different browser?

Ubuntu with firefox here

image

zoglo commented 1 year ago

Lemme look into it

therungg commented 1 year ago

Thanks @zoglo !!