therungg / therun-frontend

Frontend for therun.gg
https://therun-fr-therun.vercel.app
MIT License
26 stars 8 forks source link

Remove anchors from <Link> tags #36

Closed florence-wolfe closed 1 year ago

florence-wolfe commented 1 year ago

Next13 updated how Link tags work. They no longer allow <a> tags within the Links and should be removed. The codemod added a legacyBehavior prop for the components it couldn't remove the anchors automatically.

nextjs13 migration docs

          Hmm, didn't the codemod catch this one? I'm reading the `<a>` tag within link should be just removed. Not sure what's better, because that might come with some regression

_Originally posted by @therungg in https://github.com/therungg/therun-frontend/pull/33#discussion_r1197075421_

Acceptance criteria

Nkiriobasi commented 1 year ago

I'll work on this

therungg commented 1 year ago

Fixed by @Nkiriobasi