therungg / therun-frontend

Frontend for therun.gg
https://therun-fr-therun.vercel.app
MIT License
26 stars 8 forks source link

removed a tag inside Link tags, because there are created automatically #39

Closed Nkiriobasi closed 1 year ago

Nkiriobasi commented 1 year ago

I found the Anchor tag inside the Link tag in just one file in the whole project, so I have removed and tested.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
therun-fr ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 10:10pm
Nkiriobasi commented 1 year ago

Alright, I'll remove it but actually in the browser the fragments do not render any tag.

On Thu, 18 May 2023 at 18:14, Frank Robert @.***> wrote:

@.**** commented on this pull request.

Can we remove the empty fragments to return the contents directly in the links?

  • <>

— Reply to this email directly, view it on GitHub https://github.com/therungg/therun-frontend/pull/39#pullrequestreview-1433109876, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVD4AFT5TRQW4DVXTYBMT73XGZKGHANCNFSM6AAAAAAYGVRZZI . You are receiving this because you authored the thread.Message ID: @.***>

therungg commented 1 year ago

Hey, thanks for the PR! Unfortunately, the linter does not like the changes, and i'm not exactly sure why (looks good to me). Would you mind looking into that?

Nkiriobasi commented 1 year ago

Alright I'll

On Thu, 18 May 2023 at 22:27, therun.gg @.***> wrote:

Hey, thanks for the PR! Unfortunately, the linter does not like the changes, and i'm not exactly sure why (looks good to me). Would you mind looking into that?

— Reply to this email directly, view it on GitHub https://github.com/therungg/therun-frontend/pull/39#issuecomment-1553667026, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVD4AFWFD2EVB2AVBFVY6VTXG2H2LANCNFSM6AAAAAAYGVRZZI . You are receiving this because you authored the thread.Message ID: @.***>

Nkiriobasi commented 1 year ago

I reverted back to using the fragments, when the component renders the Link tag alone is rendered, it does not create additional Dom elements. but since we are using next 13, the anchor tag will be created automatically as a child.

On Thu, 18 May 2023 at 23:02, obasi nkiri @.***> wrote:

Alright I'll

On Thu, 18 May 2023 at 22:27, therun.gg @.***> wrote:

Hey, thanks for the PR! Unfortunately, the linter does not like the changes, and i'm not exactly sure why (looks good to me). Would you mind looking into that?

— Reply to this email directly, view it on GitHub https://github.com/therungg/therun-frontend/pull/39#issuecomment-1553667026, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVD4AFWFD2EVB2AVBFVY6VTXG2H2LANCNFSM6AAAAAAYGVRZZI . You are receiving this because you authored the thread.Message ID: @.***>

therungg commented 1 year ago

Merging, thanks! :)