Ended At time for runs does not properly account for timezones

therungg / therun-frontend

Frontend for therun.gg

https://therun-fr-therun.vercel.app

MIT License

26 stars 8 forks source link

Ended At time for runs does not properly account for timezones #60

Closed florence-wolfe closed 1 year ago

florence-wolfe commented 1 year ago

Some times are being displayed in the future

zoglo commented 1 year ago

Seems like they are in GMT+0/+1.

Any library to convert the timestamps that you may know of?

florence-wolfe commented 1 year ago

There's already momentjs and luxon installed as dependencies to the project. I think those would be a good place to start to avoid needing to install additional depenendencies.

zoglo commented 1 year ago

Tested on local environment with Los-Angeles and the times seem fine.

This issue is more of a faulty setup from people submitting runs:

system-time set up incorrectly
MineCraft plugins (RedLime) not sending the right timestamp

Needs more investigation

RedLime commented 1 year ago

yeah SpeedRunIGT has messed up timezone with upload the run, it will be fixed in new release.

RedLime commented 1 year ago

It has been fixed in latest version of SpeedRunIGT. However, there's many people still use the old version, so the same problem may occur

florence-wolfe commented 1 year ago

@therungg what do you think about adding a UI component that displays to the user uploading MC splits with times in the future notifying them of the suspected issue and recommending they update their client?

Might just be an unneeded edge case?

therungg commented 1 year ago

Don't think thats necessary. Probably not many people from MC visit the site regularly anyway honestly, so it won't be very effective either. I filter out all the in the future runs now, So they won't be visible anyway.

Going to close this issue