93 rename interfaces - Githubissues

thervh70 / ContextProject_RDD

1 stars 0 forks source link

93 rename interfaces #111

Closed mpsijm closed 8 years ago

mpsijm commented 8 years ago

Will close #93

I removed the Hungarian notation in the interfaces but in order to do that I had to make a small change:

Instead of 6 implementing classes, I have created 1 Factory that can instantiate all types of events
Instead of creating a new EventObject with e.g. new SemanticEvent(...), you now call EventFactory.semantic(...).

Is not hard to review, so have fun :D

coveralls commented 8 years ago

Coverage increased (+0.09%) to 87.648% when pulling 071e583d3370bf981ed61ebd3c87502adb9516de on 93-rename-interfaces into 850fb2585b9d3286f92ef6d11bd1a6a14ba3c243 on dev.

coveralls commented 8 years ago

Coverage increased (+0.09%) to 87.648% when pulling 5adb9de3077b9f67ba15a758ef2c808df085b4d4 on 93-rename-interfaces into 850fb2585b9d3286f92ef6d11bd1a6a14ba3c243 on dev.

MathiasMeuleman commented 8 years ago

Kill all the Hungarian notiation!! Looks good :) Thanks for adding the TSDoc, this seems ready to be merged

thervh70 commented 8 years ago

Nice solution, yet I have added a comment :P

coveralls commented 8 years ago

Coverage increased (+0.08%) to 88.441% when pulling b71e06e96706182280e9a318bcb21ece53167be4 on 93-rename-interfaces into 96ed71d57cf6044ae5239dd754c2ecab09b9994e on dev.

coveralls commented 8 years ago

Coverage increased (+0.08%) to 88.441% when pulling 4dacaf712a103a4180a44b1ec26bb3b4eb2058dc on 93-rename-interfaces into 96ed71d57cf6044ae5239dd754c2ecab09b9994e on dev.

thervh70 commented 8 years ago

Looking good now, 2 aprovals so I will merge!