thervh70 / ContextProject_RDD

1 stars 0 forks source link

89 Improve Saving Options #113

Closed mdingjan closed 8 years ago

mdingjan commented 8 years ago

Will close #89

Options are now saved automatically and don't require any interaction, besides checking a checkbox.

Main changes:

Submit button has been removed
Toasts / messages have been removed
Automatic saving has been added; a click event per checkbox.
Mehods have been refactored by creating central arrays for option parts. These arrays are looped over.

Please review! Suggestions for refactoring improvements / discussions are welcome. :)

coveralls commented 8 years ago

Coverage remained the same at 88.361% when pulling 273161a20dfaba0f4a50477632da62984a055df5 on 89-improve-saving-options into 96ed71d57cf6044ae5239dd754c2ecab09b9994e on dev.

coveralls commented 8 years ago

Coverage remained the same at 88.361% when pulling d57113885f3b2ef7892fdff6c55ca25a383c66a2 on 89-improve-saving-options into 96ed71d57cf6044ae5239dd754c2ecab09b9994e on dev.

coveralls commented 8 years ago

Coverage remained the same at 88.361% when pulling 18b0f54a579802c3bf9adf948f717cc9edeb444b on 89-improve-saving-options into 96ed71d57cf6044ae5239dd754c2ecab09b9994e on dev.

coveralls commented 8 years ago

Coverage increased (+0.08%) to 88.441% when pulling 262aa8dfbbb3427e9e60fda40c5d34787ca768df on 89-improve-saving-options into 96ed71d57cf6044ae5239dd754c2ecab09b9994e on dev.

coveralls commented 8 years ago

Coverage increased (+0.08%) to 88.441% when pulling 7ee63e258a6150dcade007dcf6539c63fd0cbf02 on 89-improve-saving-options into 96ed71d57cf6044ae5239dd754c2ecab09b9994e on dev.

MathiasMeuleman commented 8 years ago

This is looking good :) I think it wise if we wait until #84 is merged, because there are some more Options in that branch. After that is merged, I will merge this

coveralls commented 8 years ago

Coverage increased (+0.08%) to 88.441% when pulling 9517877bccb6648f84782f2e0762c28d98f69ac3 on 89-improve-saving-options into 96ed71d57cf6044ae5239dd754c2ecab09b9994e on dev.

coveralls commented 8 years ago

Coverage increased (+0.08%) to 88.441% when pulling 05d3229cc8b38e5fb300e4a6df26f76523f078a6 on 89-improve-saving-options into 96ed71d57cf6044ae5239dd754c2ecab09b9994e on dev.

coveralls commented 8 years ago

Coverage increased (+0.08%) to 88.441% when pulling 4f8c558306927f62262f57926ac4f00342b5e46e on 89-improve-saving-options into 96ed71d57cf6044ae5239dd754c2ecab09b9994e on dev.

mpsijm commented 8 years ago

Okay, for now it's looking good :D Soon #84 will be merged, so you can continue :D

coveralls commented 8 years ago

Coverage increased (+0.3%) to 88.716% when pulling cc0546bf0e705fe9fcb3a46d6c3cd06d5ba21dba on 89-improve-saving-options into 2950b817761fe48985f0aaf71691f97043254bd4 on dev.

coveralls commented 8 years ago

Coverage increased (+0.3%) to 88.716% when pulling 69cc48f6d5035176b2437d24728f95e59ecc1425 on 89-improve-saving-options into 2950b817761fe48985f0aaf71691f97043254bd4 on dev.

mdingjan commented 8 years ago

84 has been merged into this branch!

So this PR is ready for merging. Is there still someone that wants to review?

MathiasMeuleman commented 8 years ago

I will merge :)