134 push entire dom

[mpsijm]

Will close #134

Changes:

• Copied JQuery-UI's zIndex source into our repo
• Add DOMRewriter class, which can recursively add data-octopeer-* tags to DOM elements
• Let ContentController use DOMRewriter to rewrite the DOM on specific moments:
  • on load
  • when the (new) MutationObserver notices a mutation in the DOM tree

If there's anything wrong with anything, tell me! :D Else, please merge :)

[coveralls]

Coverage decreased (-0.3%) to 93.108% when pulling a68bbc3cb18933e300b8297b65b85706ebf21308 on 134-push-entire-dom into 818c5a7662dfcdbc0e82a8b7fd4617117a672ddb on dev.

[coveralls]

Coverage decreased (-0.3%) to 93.186% when pulling 34f8564767235a23b7b799912ac8b0062c0d0f18 on 134-push-entire-dom into 818c5a7662dfcdbc0e82a8b7fd4617117a672ddb on dev.

[mdingjan]

The additional lag that this feature takes with him is really noticable. xD But that's something we already expected, so that's fine. ;)

[mdingjan]

The status of the extension gets quite buggy after switching a few pull requests, which could have two causes in my opinion:

• The lag
• A new bug is born because of the changes. :bug:

I think the last one is most likely the cause.

[Exclaminator]

Nice coding style, LGTM.

[coveralls]

Coverage decreased (-0.3%) to 93.126% when pulling 2e085fb7c05a5f25dfa3072d519754efe205c568 on 134-push-entire-dom into 818c5a7662dfcdbc0e82a8b7fd4617117a672ddb on dev.

[mdingjan]

The bug has indeed been fixed; thanks! :D I've played around more and can't find any more bugs, nice! :) The functionality is there and it has been tested well now, so good job! :D

Make sure to fix the typo and you have my approval for merging this PR. :)

[coveralls]

Coverage decreased (-0.3%) to 93.126% when pulling 4e417268cf3e8002db8765f547f9e2364cc0a8fd on 134-push-entire-dom into 818c5a7662dfcdbc0e82a8b7fd4617117a672ddb on dev.

[MathiasMeuleman]

There isn't any possibility of making this faster right? The only problem is that I'm suddenly getting 400 statuscodes while typing this message, maybe something to look into? (You seem to have broken some KeystrokeEvents)

[coveralls]

Coverage decreased (-0.3%) to 93.117% when pulling afecc55210c71b746320aff695b824c6cf93fae5 on 134-push-entire-dom into 818c5a7662dfcdbc0e82a8b7fd4617117a672ddb on dev.

[mpsijm]

Nope, this part cannot be made faster. Mainly because the rewriting of the DOM has to happen in the content script, because the page cannot be reconstructed in the background page. The 400 status codes are because the space characters cannot be pushed to the database. I'll poke Aaron about that :P

[coveralls]

Coverage decreased (-0.3%) to 93.117% when pulling 1eac6e6f8b634f4f0eafd61fc07ecaa195dc7457 on 134-push-entire-dom into 818c5a7662dfcdbc0e82a8b7fd4617117a672ddb on dev.

[MathiasMeuleman]

Thanks for the rewrite, this does make it somewhat faster :) I will merge this