search

thervh70 / ContextProject_RDD

1 stars 0 forks source link

152 remove status.setter #158

Closed Exclaminator closed 8 years ago

Exclaminator commented 8 years ago

Will close #152.

After the feedback from Bastiaan about the undescriptive naming of Settings.setter the plan was to adjust the name when examining the code I came to the conclusion that this can easily be fixed with a minor refactor. the test has been updated accordingly.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.01%) to 93.444% when pulling a72f9f51544e6333a1af2fee4325416e6f0487f9 on 152_-_Remove_Status.setter into 818c5a7662dfcdbc0e82a8b7fd4617117a672ddb on dev.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.009%) to 93.448% when pulling 39124800cb258c410e365c78a8e29c26671a8dd2 on 152_-_Remove_Status.setter into 818c5a7662dfcdbc0e82a8b7fd4617117a672ddb on dev.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.009%) to 93.448% when pulling 39124800cb258c410e365c78a8e29c26671a8dd2 on 152_-_Remove_Status.setter into 818c5a7662dfcdbc0e82a8b7fd4617117a672ddb on dev.

mpsijm commented 8 years ago

Thanks for the refactoring, that's even better than renaming :) Ready for merging! :)

MathiasMeuleman commented 8 years ago

Too bad about that huge coverage decrease :P will merge this PR