153 implement the proper layout of the settings page

Exclaminator commented 8 years ago

Will close #153.

Do note that these options still have to be implemented.

coveralls commented 8 years ago

Coverage remained the same at 93.448% when pulling f8937b3e67c6988c5b9af7ce8c9660a5f940871a on 153_-_Implement_the_proper_layout_of_the_settings_page into 2f85c5ba7651a4aa546833aec478e1b117dfe921 on dev.

thervh70 commented 8 years ago

Besides the few spelling errors there are some more problematic things. Please examine the following 2 figures. Some weird things are happening with the last 2 options. Please take a look into this.

coveralls commented 8 years ago

Coverage remained the same at 93.448% when pulling b0daa239e90ca1deb5d387d1570e221690df89f6 on 153_-_Implement_the_proper_layout_of_the_settings_page into 2f85c5ba7651a4aa546833aec478e1b117dfe921 on dev.

coveralls commented 8 years ago

Coverage remained the same at 93.448% when pulling b7296da8f83f158c58b7baa5ecd154cf5734296a on 153_-_Implement_the_proper_layout_of_the_settings_page into 2f85c5ba7651a4aa546833aec478e1b117dfe921 on dev.

mpsijm commented 8 years ago

When reloading the options page, the disabled state is not restored.

Exclaminator commented 8 years ago

The last commit should fix this, good catch!

coveralls commented 8 years ago

Coverage remained the same at 93.059% when pulling c42ffef1315057321012a1e7ca652eb6b875beeb on 153_-_Implement_the_proper_layout_of_the_settings_page into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

coveralls commented 8 years ago

Coverage remained the same at 93.059% when pulling c42ffef1315057321012a1e7ca652eb6b875beeb on 153_-_Implement_the_proper_layout_of_the_settings_page into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

MathiasMeuleman commented 8 years ago

Thanks for the changes. Looking good. If someone can confirm their functionality issues are fixed, this can be merged

coveralls commented 8 years ago

Coverage remained the same at 93.059% when pulling 17fc11029c8efcd7664a93806fa3c69fc5c14746 on 153_-_Implement_the_proper_layout_of_the_settings_page into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

coveralls commented 8 years ago

Coverage remained the same at 93.059% when pulling 17fc11029c8efcd7664a93806fa3c69fc5c14746 on 153_-_Implement_the_proper_layout_of_the_settings_page into 9ff62c72ccfbd7f683c53120f1d973f0193d2b14 on dev.

mpsijm commented 8 years ago

I have tried to break the options page again but I didn't have success in letting it fail. :D Will merge! :)

thervh70 / ContextProject_RDD

153 implement the proper layout of the settings page #160